Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dart_flutter_team_lints for matcher #2426

Merged
merged 6 commits into from
Dec 13, 2024

Conversation

natebosch
Copy link
Member

Change the dependency and analysis options include to the stricter team
configuration.

Fix newly surfaced diagnostics. Most code changes are related to the
strict modes that are enabled by the team config.
Fix most implicit casts with explicit casts, but fix some arguments in
typedMatches implementation so they don't unnecessarily widen the type
back to dynamic before using the value.

Change the dependency and analysis options include to the stricter team
configuration.

Fix newly surfaced diagnostics. Most code changes are related to the
strict modes that are enabled by the team config.
Fix most implicit casts with explicit casts, but fix some arguments in
`typedMatches` implementation so they don't unnecessarily widen the type
back to `dynamic` before using the value.
@natebosch natebosch requested a review from a team as a code owner December 13, 2024 00:18
@natebosch
Copy link
Member Author

Replaces dart-archive/matcher#251

Copy link

github-actions bot commented Dec 13, 2024

PR Health

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

The min SDK for the test runner is already at 3.5.0 and matcher is only
usable with the latest version of the test runner.
@natebosch natebosch merged commit 6719bc6 into master Dec 13, 2024
60 checks passed
@natebosch natebosch deleted the match-dart-flutter-team-lints branch December 13, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants